Subject: [multipathtcp] RFC6824bis-04 ADD_ADDR2 comments

From: "Demaria, Fabrizio" <[email-masked]>
Date: Tue, 20 Oct 2015 09:00:55 +0000

Hello,

On the document RFC6824bis-04, where ADD_ADDR2 implementation is specified, there are two points I would like to discuss regarding the following statement:

"The key used in the HMAC calculation is that of the sender,
as originally declared in the MP_CAPABLE handshake. The message for
the HMAC is the Address ID, IP Address, and Port which precede the
HMAC in the ADD_ADDR2 option."

This is the indicated procedure to calculate the HMAC to be added in ADD_ADDR2.
I think it should be specified how to handle the case in which the Port is not present (being optional).
Moreover, since we have the SHA-1 hash algorithm already implemented for MP_CAPABLE that takes two keys as input, it would be good considering to use both the key of the sender and the one of the receiver for ADD_ADDR2, too. This might ease reuse of code and add some security improvement overall.

Thank you,
Fabrizio

----------------------------------------------------------------------
Intel Sweden AB
Registered Office: Knarrarnasgatan 15, 164 40 Kista, Stockholm, Sweden
Registration Number: 556189-6027

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.