Subject: [COSE] AD Review of draft-ietf-cose-hash-sig-03

From: Roman Danyliw <[email-masked]>
Date: Thu, 10 Oct 2019 17:17:25 +0000

Hi!

The following is my AD review of draft-ietf-cose-hash-sig-03:

** Section 3.  Per "The signature value is a large byte string.  The byte string is designed for easy parsing, and it includes a counter and type codes that indirectly provide all of the information that is needed to parse the byte string during signature validation."
-- please propagate the clarifying edits of the form made on the related sentence of Section 3.0 in draft-ietf-lamps-cms-hash-sig (to clarify the exact parameters in the byte string and where this byte string is defined)

-- the examples in Appendix A seem to imply a particular formatting (e.g., using the | to separate parameters), this should be clarified in this text

 ** This draft (COSE) and draft-ietf-lamps-cms-hash-sig (CMS) share common text.  A number of changes were made to draft-lamps-cms-hash-sig in response to AD feedback and the IESG review (version -09 and -10).  Please propagate these changes (where they are appropriate):

-- Abstract and Section 1.  Expand "HSS/LMS".

-- from CMS Section 1.0 to COSE Section 1.0

-- from CMS Section 1.3 to COSE Section 1.1

-- from CMS Section 2.0 to COSE Section 2.0

-- from CMS Section 2.1 to COSE Section 2.1

-- from CMS Section 2.2 to COSE Section 2.2

-- from CMS Section 2.3 to COSE Section 2.3

-- from CMS Section 6.0 to COSE Section 6.0

Regards,
Roman