Subject: [mile] Consistency in @indicator-uid/set-id attributes

From: "Roman D. Danyliw" <[email-masked]>
Date: Thu, 9 Jan 2014 19:38:15 +0000

Hello!

I reviewed the -03 draft to examine where @indicator-uid and @indicator-set-id attributes are present in the document.  Each instances of these attributes should be found documented in three places: in the text describing the class,  in the diagram depicting the class, and in the schema.  

The following classes have @indicator-uid and @indicator-set-id attributes fully documented: HistoryItem, Expectation, Reference, Assessment, RecordData, HashInformation, and Service.

A few inconsistencies were found in the review.

Editorial mistakes
===============
** Address = @indicator-set-id not found in text but in the diagram and schema
** DomainData = @indicator-uid and set-id in schema, but not in text or diagram (expected and tracked in Issue #15)

Inconsistencies that pose questions
==============================
** EmailDetails = has @indicator-uid but no set-id in the schema.  There is not text or diagram due to Issue #15.  I recommend we add @indicator-set-id.  I believe this was an editorial mistake.  Agreed?
** Incident = has @indicator-set-id but not uid.  Was excluding @indicator-uid intentionally?
** EventData = has @indicator-set-id but not uid.  Was excluding @indicator-uid intentionally?
** RegistryKeyModified = has @indicator-uid and set-id in the schema by not in the text.  See Key for recommendation.
** Key = has @indicator-uid and set-id in the text and diagram but not in the schema.  These attributes should be in either RegistryKeyModified or Key, but not both.  I would recommend that these attributes be in Key.

Roman