Subject: Re: [nfsv4] SET_SSV4res improperly specified

From: Mike Eisler <[email-masked]>
Date: Thu, 1 Mar 2007 02:17:53 -0800 (PST)

--- Fredric Isaman <[email-masked]> wrote:

> SET_SSV4res has no way to return error codes.  Below is a patch that 
> encodes the result in a manner consistent with other operations.

Good catch Fred. Thanks.

> 
> In a similar vein, the list of legitimate error codes for SET_SSV
> seems a 
> little short.  In particular, at least NFS4ERR_OP_NOT_IN_SESSION
> should be
> added.

I probably won't get around to cleaning up the all the
error lists until draft-10.
> 
>  	Fred
> 
> 
> 
> 
> 
> 
> 
> 
> --- nfsv41.x	2007-02-27 13:46:35.000000000 -0500
> +++ new_nfsv41.x	2007-02-28 14:33:25.000000000 -0500
> @@ -2084,10 +2084,18 @@
>   	opaque		ssa_digest<>;
>   };
> 
> -struct SET_SSV4res {
> +struct SET_SSV4resok {
>   	opaque		ssr_digest<>;
>   };
> 
> +union SET_SSV4res switch (nfsstat4 status) {
> +case NFS4_OK:
> +	SET_SSV4resok	ssr_resok4;
> +default:
> +	void;
> +};
> + 
> +
>   struct TEST_STATEID4args {
>   	stateid4	ts_stateids<>;
>   };
> 
> _______________________________________________
> nfsv4 mailing list
> [email-masked]
> https://www1.ietf.org/mailman/listinfo/nfsv4
> 

_______________________________________________
nfsv4 mailing list
[email-masked]
https://www1.ietf.org/mailman/listinfo/nfsv4