Subject: [PCN] draft-babiarz-pcn-3sm-00 pseudocode nit

From: Bob Briscoe <[email-masked]>
Date: Thu, 30 Aug 2007 09:11:17 +0100

Joe,

In the admission marking pseudo-code in draft-babiarz-pcn-3sm-00 S.2.2.2, 
if a packet arrives that is larger than the current depth of the token 
bucket, you correctly mark the packet with admission stop marking, but I 
think you've omitted to empty the bucket to zero as well.

/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\
      if (TB.fill < packet.size)
          TB.fill = 0;           // BB: Suggested amendment
          packet.mark = AS;
      else
          TB.fill = TB.fill - packet.size;
          if (TB.fill < TB.threshold)
              packet.mark = AS;
          endif
      endif
/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\

Bob

____________________________________________________________________________
Bob Briscoe, <[email-masked]>      Networks Research Centre, BT Research
B54/77 Adastral Park,Martlesham Heath,Ipswich,IP5 3RE,UK.    +44 1473 645196 

_______________________________________________
PCN mailing list
[email-masked]
https://www1.ietf.org/mailman/listinfo/pcn