Subject: [issue1] Feedback: Section 6.2

From: Jamal Hadi Salim <[email-masked]>
Date: Mon, 1 Nov 2004 03:10:19 +0000

New submission from Jamal Hadi Salim <[email-masked]>:

These are captured here auntil closed by discussions

--------
        main hdr (eg type =  Association setup)
             |
             |
             +--- T = LFBselect
             |        |
             |        +-- LFBCLASSID = FE object
             |        |
             |        |
             |        +-- LFBInstance = 0x1
             |
             +--- T = Operation = SHOW
                      |
                      +-- FE NAME

---------------

The operation is Not part of the LFBSelect.

It should be:

--------
        main hdr (eg type =  Association setup)
             |
             |
             +--- T = LFBselect
                     |
                     +-- LFBCLASSID = FE object
                     |
                     |
                     +-- LFBInstance = 0x1
                     |
                     +--- T = Operation = ADVERTISE
                           |
                           +-- FE NAME
---------------

If you want to leave it there call it PENAME as i suggested.

Hormuzd was planning to send an update to this.

More:
In the diagram: 
+ LFB Instance ID  and LFB Class ID 
should those just be set to 0x1? We already know thats where they are
going.
+ Type = operation, using the word "type" is confusing since it is also
used in the main header. I dont think we can avoid using the word type
in TLVs; my suggestion is we consider changing the main header type to 
"command". Thoughts? It is a command after all.
+ comment on SHOW applies here as well

+ "HBI will be exchanged with the CE using this LFB" ???
+ Length should specify what length is covered by the TLV.

-6.2.2  Association Setup Response Message

In the diagram: 
+ LFB Instance ID  and LFB Class ID 
should those just be set to 0x1? We already know thats where they are
going.
+         
+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
|        Type = operation Show  |               Length          |
+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
|                                                               |
~                   FE Object LFB (optional)                    ~
|                                                               |
+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+

What is that?

+ "HBI will be exchanged with the CE using this LFB" ???

+ Type = T.reason  ?

This brings up that we need the following speacial TLVs.

FORCES_REASON, FORCES_RESULT, FORCES_NAME.

----------
category: Technical
draft: draft-ietf-forces-protocol
messages: 1
nosy: jamal
priority: Must fix
status: Pending
title: Feedback: Section 6.2

__________________________________________________
Forces issue tracker <[email-masked]>
<http://www.mip4.org/issues/tracker/forces/issue1>
__________________________________________________