Subject: [Idr] draft-li-idr-bgp-ls-sr-policy-path-segment

From: Shraddha Hegde <[email-masked]>
Date: Mon, 6 May 2019 10:31:05 +0000

Authors,

Some comments on the draft.

1.      Section 3.1 SR Path Segment
"Also, it can be used for identifying an SR candidate path or an SR
   Policy defined in [I-D.ietf-spring-segment-routing-policy<https://tools.ietf.org/html/draft-li-idr-bgp-ls-sr-policy-path-segment-01>]."

When the path-segment is used for identifying SR policy/candidate path,
The SR Path Segment sub-TLV should appear in the SR policy as below. Pls update figure 1.

SR Policy SAFI NLRI: <Distinguisher, Policy-Color, Endpoint>
           Attributes: Tunnel Encaps Attribute (23)
           Tunnel Type: SR Policy
               Binding SID
               Preference
               Priority
               Policy Name
               Explicit NULL Label Policy (ENLP)
               Path Segment
               Bidirectioanl Path
                   Segment List
                       Weight
                       Segment
                       Segment

The Path Segment Sub-TLV may be associated with SR Policy as well as the Segment List
Simultaneously, or may be associated with SR-Policy or segment List alone based on usecases.
2.      I suggest to update the IANA section, with code points and NLRIs/attributes where the TLVs/sub-TLVs appear in BGP-LS NLRI
      Along with the code-points. It's useful for implementors as well as IANA to keep the registry up to date.

      Rgds
      Shraddha